if ($val != "0")

[download]

You are using a numerical comparison on a text value which means that Perl has to convert the text values to numbers.    Normally Perl will make the correct conversion but this may cause problems. 



            @values=(@values,$val);

[download]

That is usually written as: 

            push @values, $val;

[download]


&maximum(@values,$arraysize);

...

sub average
      {
      @stuff = @_;
      my $sum = 0;
      ($sum+=$_) for @stuff;
      my $average = $sum / $arraysize;
      return $average;
      }

[download]

It looks like you meant average instead of maximum here?    You are passing $arraysize as well as @values to this subroutine which means that @_ inside the subroutine will have one more value than the numbers you want to calculate the average for.    You could simply remove that value using pop but there is no reason to pass the value in the first place as @_ would then have the same number of elements as @values and using @_ in scalar context would result in the same value as using @values in scalar context.

In reply to Re: Passing an array to a subroutine help?! by jwkrahn
in thread Passing an array to a subroutine help?! by Douglas0028

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.