I strongly recommend that you keep the scope of lexical variables as small as possible. Generally you should only declare variables where they are initialised. Removing the block declaration of variables in the visit call back sub, then adding my where each variable is first initialised turns up the following dubious code:

        my $newtitle   = HTML::Element->new ('title');
        $newtitle   = $newtitleh1;
        my $newtitleh1 = $tree->look_down ('_tag', 'h1');

[download]

I also note the use of nested named subroutines which almost certainly is a mistake.

Aside from that, writing the same dozen lines of code four times should be a strong clue to use a sub.

Using named subs for the visit and broken link call backs would help clarify program flow and make the function of the various parts of the code clearer.

True laziness is hard work

In reply to Re^4: Trying to Insert Alt Tags Programmatically by GrandFather
in thread Trying to Insert Alt Tags Programmatically by socrtwo

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.