This is what I came up with. It does essentially the same as
your program, but it's a little bit shorter. Notice that I
dropped the
close altogether, because
open automatically
closes the file handle if it was previously opened (see
perlopentut
-- I wouldn't consider this a good programming
practice, but I'm assuming this is a one-shot program here),
so you don't have to keep track of whether file is open. Also,
you don't need to read the whole file in memory at once.
use strict;
my $n="0000";
while (<>) {
if (/^<\?xml version/) {
open OF, ">outfile_$n.xml" or die "open: $!\n";
$n++;
}
print OF $_;
}
--ZZamboni
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
|
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.