my (@file_change,@backup);
my ($time2,$change,$file,$files);

[download]

You should declare variables as close as possible to where there are defined instead of all at the beginning. 



open my $report, ">", "report.txt";

[download]

You should always verify that the file opened correctly before trying to use a possibly invalid filehandle. 



for $file (</tmp/*>) {

[download]

The files in /tmp are temporary, why would you want to save them? 



@file_change = stat($file);
$time2 = $file_change[9];
# (day = 86400, week = 604800)
$change = (time - $time2);
push @backup, $file if ($change < 604800) ;

[download]

If you just want time periods based on days then you could use the -M operator. 



# function to create tarball and backup changed files;
sub backup {
        $files = "@backup";
        system ("tar -czvf backup.tgz $files") ;

}

# run backup function
backup();

[download]

Why does this need to be a subroutine?    You should verify that system succeeded.

In reply to Re: Perl backup script by jwkrahn
in thread Perl backup script by techjohnny

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.