#!/usr/bin/perl use strict; use warnings; use File::Copy; #change this to 0 and execute, then back to one and execute my $value0 = 1; my $value1 ='true'; ## marmot: open for overwriting open (INFO, "> tmp"); print INFO "this is simple\n"; close (INFO); ## marmot: open RESULT_LOG for appending open (FILE, ">> RESULT_LOG") ; print FILE " STATUS obtained : $value1\n"; # If true then copies the information to the RESULT_LOG ## marmot: translation --> if $value0 is true, overwrite RESULT_LOG wi +th tmp. ## By the way, <FILE>, which is RESULT_LOG, is still open for +appending, ## so this is probably a bad idea. if ($value0 == 1) { copy("tmp","RESULT_LOG");} ## marmot: Otherwise, append RESULT_LOG with text. else { print FILE "Check keyword supplied\n"; } close(FILE);
Apart from confusing copying with appending, and trying to overwrite a file that's already open for appending, this code can be made to work with the changes below.
if ($value0 == 1) { open INFO, "<tmp"; print FILE <INFO>; # Appends to RESULT_LOG else { print FILE "Check keyword supplied\n"; } close(FILE); close(INFO);

I realize this is just a snippet to show what you're trying to accomplish, but I have to wonder if it makes sense to open 'tmp' and write text to it, when you're just going to append it to another file later. Why not put this information in a variable and keep it around until you need to write it to a file?

Also, for the sake of your own clarity, you might want to give your file handles names that are closer to the file names they represent, or perhaps the functions they perform. E.g.,

open TMP, "<tmp"; open LOG, ">>RESULT_LOG"; open RESULTS, ">>RESULT_LOG";

--marmot


In reply to Re^3: Is there a way to avoid copy function from overwriting old contents? by furry_marmot
in thread Is there a way to avoid copy function from overwriting old contents? by justkar4u

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.