1. return should always (except in a few special situations) be within a sub. Where do you expect the line return @records; to return to?
  2. The first two lines of sub events seem to be misplaced.
  3.     my ($n, @list);
    ($n, @list) = @_;

    [download]

    is better written

    my ($n, @list) = @_;

    [download]
  4. foreach $_ (@list) is just wrong. Use either foreach (@list) or 
    foreach my $item (@list) {
    my @tokens = split ' ', $item;
    ...

    [download]
  5. Reusing the same name for variables in the same area of code (@list for example) is at best confusing and at worst is completely wrong - don't do that
True laziness is hard work

In reply to Re: Lexical scope by GrandFather
in thread Lexical scope by velocitymodel

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.