You've quite obviously already taken the time to come up with the code, and though this looks quite good for you current case, this will break if your CSV data gets more complicated like having UTF8 encoded data or embedded newlines, this approach will break. I'd advice you to use the more safe way (note that I did not change anything else, see GrandFathers answer for changes). I have commented all my changes:

my $csv = Text::CSV->new ({ binary => 1, # Allow utf8 and embedded newlines auto_diag => 1, # make detecting CSV errors easy }); # open into a lexical file handle open my $fh, "<", $file or die "$file: $!"; my @content; my %masterlist; $csv->getline ($fh); # skip first line # @hdr = @{$csv->getline ($fh)}; would save it for header info # $csv->getline () respects $/, but reads past embedded newlines while (my $row = $csv->getline ($fh)) { $masterlist{$row->[0]} = $row->[1]; # auto_diag takes care of the failures } close $fh;

See how much shorter that also gets?


Enjoy, Have FUN! H.Merijn

In reply to Re: Please help with CSV by Tux
in thread Please help with CSV by bones07

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.