One major problem is that you tend to forget the dollar sign before your variables. Take this line, for example: 
elsif (x = max - 1)

[download]
You should probably add this line near the top, and then declare your variables with my: 
use strict;

[download]
It will help you catch these kinds of errors.

Update: I believe that if() statements and for() loops require curly braces, even if they are one-liners. Code such as this: 

for (...)
  if (...)
    ...blah...

[download]
should be like this: 
for (...) {
  if (...) {
    ...blah...
  }
}

[download]
buckaduck

In reply to Re: home work help by buckaduck
in thread home work help by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.