Nice. I can't see this kind of follow-ups often enough!

A few comments, naturally:

  1. use strict warnings and diagnostics or die. These are your friends on the long run.
  2. You declare 2 vars without need:
    my %h1 = %{ $_[0] }; #h2 similar
  3. Check whether your refs are defined:
    my %h1 = (defined $_[0] and ref $_[0]) ? %{ $_[0] } : ();
    This will make the code more portable/general/cleaner. You may add an extra check for hashiness.
  4. I just realized that this code can't distinguish between undefined or empty, so the grep becomes:
    scalar grep { my ($a, $b) = ( $h1{$_}, $h2{$_} ); ( not defined $a and defined $b ) or ( not defined $b and defined $a ) or $a ne $b } @k1
    Had to think extra carefully there!

Hope this helps,

Jeroen


In reply to Re:{3} How to test equality of hashes? by jeroenes
in thread How to test equality of hashes? by acser

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.