There's no need to use a while-loop around the call to find.

Also your current approach is very error-prone: it will result in an infinite loop if one of the files is not found, even if the rest of the code worked. Try this instead:

my %search_for; $search_for{$_} = 1 for @input_array; find({ wanted => \&edits}, $dir); print "Couldn't find these files: ", join(', ', keys %search_for), "\n"; sub edits { my $file = $_; if ($search_for{$file}) { print "Found $file, we were looking for it!\n"; delete $search_for{$file}; # do the copying etc. here } }

In reply to Re: recursive loop and performace issue in find::file by moritz
in thread recursive loop and performace issue in find::file by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.