Yes, but consider a change needing to be made down the line:

Q: "Hey petdance we're porting this script to Unix, can you make it run there too?"

A: "Sure, I'll just change the constant."

Q: "Hey what did you change in that script so that now it doesn't work on NT anymore?"

A: "Hmmmmm"

Ok, so the example is a stretch, but imagine the solution using a sub instead of a constant.

sub LINKS {
    if (sub_to_determine_OS() =~ /(Unix|Linux)/) {
        return "/u/jreades/links.txt";
    } else {
        return "U:\jreades\nt_links.txt";
    }
}

[download]

And all of that requires exactly no changes to the rest of your application.

Yes, it is paranoid, but that doesn't mean they're not out to get you.

In reply to Re: Re: Re: I know this code could be better... by jreades
in thread I know this code could be better... by derek3000

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.