A few points:

• First, your regular expression looks fishy: /$remote_addr}/. Are you sure you need the } there?
• Your regular expression isn't anchored. It will also give a match if it finds 163.103.135.132 in the file. Or, for that matter, 63010311352132, because . has a special meaning in regular expressions. You should probably use index, or perhaps eq, depending on what is in ipfile.txt.
• You only check the first line of the file - if that is not a match, you exit the loop.
• There is no need to read in the entire file into an array, and then loop over the array. And if you loop over an array, use Perl idiom, not C idiom. Here's how I would write it:

          open my $file => "<", $ipfile or die "Open: $!";
          my $found;
          while (<$file>) {
              next if -1 == index $_ => $remote_addr;
              print "Added new guest\n";
              $found = 1;
              last; 
          }
          print "Guest not found\n" unless $found;
  [download]

  If I did need the array (in other parts of the program), I would write the loop as:

          my $found;
          foreach (@ipfconts) {
              next if -1 == index $_ => $remote_addr;
              print "Added new guest\n";
              $found = 1;
              last;
          }
          print "Guest not found\n" unless $found;
  [download]

-- Abigail

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.