(Hi to a fellow Cambridge person...)
Note that these are mostly style issues, aimed at readability.

You are doing a lot of checking of parameters. 2 ways I use to make this clearer (and 1 other comment) are :

1. Use prototypes, e.g.

   sub CompareTrees($$\%\%)
   [download]

   Perl will check that you are getting 2 scalars and 2 hashrefs and generate an error for you if not met. If the caller provides a hash, not a ref, Perl also generates the ref for you - DWIM.
2. Count the parameters passed in. e.g.

   sub CompareTrees
   {
      @_ == 4 ||
         warn "CompareTrees($srcPath,$destPath,\%srcTree, \%destTree)" &&
         return undef;
      my ($sourcePath,$destPath,$sourceTree, $destTree) = @_;
   [download]

   I think that is clearer and quicker to read and doesn't reduce reduce the usability.
3. You are checking for errors within CompareTrees and then returning undef, only to die in the caller if you return the undef. If you are going to die anyway, you may as well do it where you find the error.

   sub CompareTrees
   {
      @_ == 4 ||
        die "CompareTrees($srcPath,$destPath,\%srcTree,\%destTree)";
      my ($sourcePath,$destPath,$sourceTree, $destTree) = @_;
   [download]

   
   Personally, if I am checking in one place, I don't check in the other unless I am feeling paranoid, and try to throw the exception as close to the error as possible. This just makes the code flow more easily.

Config::IniFiles will do the Config file reading for you.
--
Brovnik

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.