When I'm passing many arguments to a sub I often bundle them up into a hash ref and pass that. Similarly, if the sub returns many arguments I pass them back in a hash ref too. One advantage of using a hash (i.e. named arguments) in such cases is that you're not relying on the position of the arguments. With many arguments that can start to get tricky. Building hashes also let me easily introduce lots of vertical white space. While some monks pour scorn on such a style I find it reads better. So there! :-)

If your dates and scores are in an AoH you can let Perl load them into a couple of tmp vars and print those rather than a long list of indexed array elements. To my eyes it looks neater and, with well chosen var names, can be self documenting.

When you're dealing with complex data structures and you're struggling to disentangle them it's worth having a look at Data::Dumper to work out what is happening.

Untested and doesn't compile. 


my $args = {
  balance_sheets  => \@balancesheets,
  cashflows       => \@cashflows,
  pnl             => \@pn1,
  # etc.
  # etc.
};

my $F = piotroski($args);

my (@dates, @scores);
push @dates,  $F->{date}[$_]{$co_name}  for (0..4);
push @scores, $F->{score}[$_]{$co_name} for (0..4);

print join(qq{\t}, @dates), qq{\n};
print join(qq{\t}, @scores);

sub piotroski {
  my $args = shift;
  #
  # do something with args
  #
  my $F = {
    date      => $date_ref,
    score     => $F_SCORE_ref,
    score_box => $F_SCORE_BOX_ref,
    roa       => $F_ROA_ref,
    # etc.
    # etc.
  }
  
  return $F;
  
}

[download]
updated: fixed key name typo

In reply to Re: Referencing/returning array of hashes from sub by wfsp
in thread Referencing/returning array of hashes from sub by PoGGiE

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.