If this is an educational program I have 2 issues with it:
- you do not use strict or warnings: adding a couple of my here and there does not make the script more verbose but let you show students a piece of code that follow the accepted best practices in the Perl community,
- the core of your script is the same line, repeated 8 times: this is most definitely a case where you should use a loop to simplify the code. A good part of learning programming involves learning how to extract similar operations and put them in a loop or in a subroutine, and I really think students should be exposed to it as early as possible.
Here is an example of how you can write this:
#!/bin/perl -w
use strict;
my $input;
do {
print "Enter a character or word: ";
chomp( $input = <STDIN>);
my @chars = split ('',$input);
foreach ( @chars )
{ my $dec = ord( $_);
my @bin;
for( reverse 0..7)
{ if( $dec >= 2**$_) { push @bin, 1; $dec -= 2**$_; }
else { push @bin, 0; }
}
print "$_: " . join('',@bin) . "\n";
}
}while( $input);
While this is probably not the most clever, or even the clearest piece of code that could be written to solve your problem (the for (reverse 0..7) is a bit kludgy for example) I think it would be a better example to students than the original version.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.