my $message = uc(<>);
$message =~ s/[^A-Z0-9]//gi; # remove punct, etc
$message =~ s/j/i/gi;
$message =~ s/q/O/gi; # replace [Qq] with [Oo]
$message =~ s/\s+//g; # remove spaces
-
You UPPER case the contents of $message at the beginning so the use of the /i option seems strange. Why not just use upper case letters in the pattern?
-
Your comment says "replace [Qq] with [Oo]" but that is not what your code is doing.
-
Your last substitution attempts to remove "spaces" which were already removed by your first substitution
-
And your code would be more efficient using transliteration instead of substitution:
my $message = uc <>;
$message =~ tr/A-Z0-9//cd; # remove punct, etc
$message =~ tr/JQ/IO/;
Update:
my @range = ("Q","V","X","Y","Z",);
...
my $i = int(rand(4));
my $letter = $range[$i];
Your @range array contains five elements but you are only accessing the first four of them.
That is usually written as:
my @range = ("Q","V","X","Y","Z",);
...
my $letter = $range[ rand @range ];
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.