Fellow Monastians,

I've always used placeholders, but was wondering about the safety, or not, of concatenating a query statement with column names. So, note the concatenation at the end of $stmt = below:

my $sort_by = ($sort eq 'date') ? 'date_of' : 'user_name';

my $stmt = 'SELECT * FROM time_sheet WHERE user_id = ? ORDER BY '.$sor
+t_by; 
my $user_time = $dbh->selectall_arrayref($stmt, {Slice => {}}, $user_i
+d);

[download]

vs. the long-hand method:

my $stmt;
if ($sort eq 'date') {
   $stmt = 'SELECT * FROM time_sheet WHERE user_id = ? ORDER BY date_o
+f'; 
} else {
   $stmt = 'SELECT * FROM time_sheet WHERE user_id = ? ORDER BY user_n
+ame';
}

my $user_time = $dbh->selectall_arrayref($stmt, {Slice => {}}, $user_i
+d);

[download]

Obviously the first one is a bit more streamlined, but unsure of the safety of it. Thoughts?

—Brad
"The important work of moving the world forward does not wait to be done by perfect men." George Eliot

In reply to Safety of concatenating query string by bradcathey

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.