You seem to be opening the output files multiple times in the foreach loop at the end, that will not only affect the running time but also can be the source of your data lost issue. So open the file before looping:
open my $fh, '>>', $filename;
foreach my $uniquekey ( keys %myHash ) {
...
print $fh ...;
};
close($fh);
If this is a one time script then don't worry *much* about the following but if you have to maintain it over time consider the following:
- use strict and use warnings
- Naming Conventions, variables like myHash, uniquekey, ... complicate understanding the script, instead use name that reflects their contents
- Use proper scope and define variables only when you need them
- Instead of `ls | grep CVS` use opendir, readdir functions
- Use functions to divide the code into meaningful pieces
- Use autodie
- Use three arg open calls instead of sysopen
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.