There are a few bad things going on. First, change the name of the sub to something else; "menu" is used by one of the other modules, and there is a name collision.

Second, $address doesn't get initialized anywhere. Third, don't print from the sub, return the value.

Last, the uri_escape interpolation seems to be wrong somehow, but I didn't try to rewrite it as is, because it's hard to read, and you're doing it three times needlessly. Instead, call it outside of the qq statement. Try something like this:

Main script:
#!/usr/bin/perl -w use strict; use CGI qw(:standard); use URI::Escape; require "call_b.pl"; my $go_menu = &menu2; print "Content-type: text/html\n\n"; print $go_menu;
call_b.pl
#!/usr/bin/perl -w use strict; use CGI qw(:standard); use URI::Escape; my $address = uri_escape("some address"); sub menu2 { return qq| <td> <ul> <li><a href="home.pl?contatc=$address&amp;selected_tab=a" targ +et="_top">home<b></b></a></li> <li>etc..</li> </ul> </td> |; } 1;

In reply to Re: SCALAR ref error help! by delirium
in thread SCALAR ref error help! by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.