You don't have to ask me twice to crack a favorite beverage... done.

I've inherited a lot of crappy code, some of it in Perl (but to be fair, lots more in Java). A few years ago I had to change a script with this code to to add leading zeroes to day and month values less than 10: 

sub add_zero { $x = shift; return $x if ( $x > 9 ); return ( '0' . $x 
+) if ( $x < 10 ); }

[download]
I'm not proud of this but I'll admit I "fixed" it with this: 
sub pad
{
    my $n = shift;
    return $n if $n =~ /\D/;
    return $n > 9 ? $n : "0$n";
}

[download]
I've never gotten around to fixing that because it always works... so far. But maybe this would be better? (suggestions welcome) 
$n = $n =~ /^\d/ ? sprintf('%02d', $n) : $n;

[download]
There is lots more, mostly not mine, some definitely more WTF, but it will take some time to dig through the CVS history and pull out the most entertaining.

In reply to Re: TIMTOWTDI meets Rube Goldberg by iguanodon
in thread TIMTOWTDI meets Rube Goldberg by Tanktalus

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.