I think there needs to be a condition so that the last substr is only run if needed. I came up with a similar coding.. If speed is of interest, then I would benchmark these substr approach vs the regex. I've found that sometimes the s/// can be slow, but the regex engine evolves all the time so benchmarking would be the only way to really know for the Perl that is being used.
#!/usr/bin/perl -w
use strict;
my @strings = qw ( ACTGCTAGGGGGGG TCAGCTAGCNA
ACTGSCGACAAAA GTCTGAGTTATTT);
foreach my $str (@strings)
{
my $last_char = substr ($str,-1,1);
my $cur_index = -1;
while (substr ($str, --$cur_index,1) eq $last_char){}
print "old: $str \n";
substr ($str,$cur_index+1,-$cur_index-3,"") if ($cur_index < 3);
print "new: $str\n";
}
__END__
old: ACTGCTAGGGGGGG
new: ACTGCTAGG
old: TCAGCTAGCNA
new: TCAGCTAGCNA
old: ACTGSCGACAAAA
new: ACTGSCGACAA
old: GTCTGAGTTATTT
new: GTCTGAGTTATT
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.