Here's a snippet of how I would approach your example in my attempt at "good code". Just another opinion, mind you.

#!/usr/bin/perl
use strict;
use warnings;
 
my $voltage;
my $current;
my $resistance;

print "I will calculate whatever
you specify according to Ohm's law. 
What shall I calculate? \n";

menu();

sub menu() {
print "\n";
print <<EOF;
Press 1 for voltage.
Press 2 for current.
Press 3 for resistance.
Press x to Exit.
EOF

my $selection = <STDIN>;
     chomp $selection;

if ($selection == 1) {voltage();}
elsif ($selection == 2) {current();}
elsif ($selection == 3) {resistance();}
elsif ($selection =~ /x,X/ {all_done();}
else {print "\nSorry, that isn't on the menu. Try again!\n";}
menu();
}

[download]

In reply to Re: What makes good Perl code? by RedElk
in thread What makes good Perl code? by slinky773

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.