Allow me one minor nitpicking.

Even if you don't use some more complicated regex like Marshall mentions, instead of writing

if ($current =~ /mA/) { $current =~ s/mA//; ... }
it's better to write either
if ($current =~ s/mA//) { ... }
or, if you prefer,
if ($current =~ /mA/) { $current =~ s///; ... }

This avoids code duplication so now if someone wants to change your program they can't make a mistake like changing only one of the regexps and causing the code to recognize the suffix but not remove it. This isn't too important in this simple case of course.

PS. yes, I think it's good perl code, except for the too many empty lines.


In reply to Re: What makes good Perl code? by ambrus
in thread What makes good Perl code? by slinky773

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.