Your problem is the nested subroutine. It's a named subroutine, and it gets compiled once. It's not a reference to a sub, so no closure is created - and that's exactly what you want here. You're likely to find that the following works better: 
sub extractlinks {
      my($url, $linktype) = @_;
 
      my @sublinks = ();
      my $callback = sub {
          my($tag, %attr) = @_;
          return if $tag ne $linktype;
          push(@sublinks, values %attr);
      }
 
      my $p = HTML::LinkExtor->new($callback); 
 
      my $res = $ua->request(HTTP::Request->new(GET => $url),
                             sub {$p->parse($_[0])});  
 
      my $base = $res->base;
      return map {$_ = url($_, $base)->abs; } @sublinks; 
}

[download]

-- Abigail

In reply to Re: Subroutine not working quite right by Abigail
in thread Subroutine not working quite right by E-Bitch

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.