I'm learning perl, and I'm trying to write a subroutine that will shuffle a deck of card, but not getting the whole deck back, why?

#!/usr/bin/perl

require 'obj13-lib.pl';

@deck = ("A H","2 H","3 H","4 H","5 H","6 H","7 H","8 H",
     "9 H","10 H","J H","Q H","K H",
     "A D","2 D","3 D","4 D","5 D","6 D","7 D","8 D",
     "9 D","10 D","J D","Q D","K D",
     "A C","2 C","3 C","4 C","5 C","6 C","7 C","8 C",
     "9 C","10 C","J C","Q C","K C",
     "A S","2 S","3 S","4 S","5 S","6 S","7 S","8 S",
     "9 S","10 S","J S","Q S","K S");

{
for(@deck){
s/H/Hearts/;
s/D/Diamonds/;
s/C/Clubs/;
s/S/Spades/;
}
print"original deck:\n";
print"@deck\n";
@hand = shuf(@deck);
print"shuffled deck:\n";
print"@hand\n";
}

sub shuf
{                                                                     
+                                                                     
+                                  
foreach $_ (@deck){
  $lastcard = pop(@deck);
  $firstcard = shift(@deck);
  push(@newdeck,$firstcard,$lastcard);}

@answer = @newdeck;
return @answer;                                                       
+                                                                     
+                                  
}
[download]

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.