First off, you're greping for $user on a list with the single element of ("karma.txt"). That will always return a $results of 0 (I think, or maybe undef) unless the user's name happens to be "karma" (or "karma.txt", or "kar", etc). I'm guessing that's not what you mean.

I think you're trying to avoid reading in the whole file if the user does not exist. Unfortunately, you can't <update>because you end up reading in the whole file before searching it anyway</update>. So you might as well go ahead and avoid the extra logic...

(Note! This is untested!!) 

use File::Slurp;

if($msg =~ /(.*)\+\+/) {
  my $user = $1;

  my @lines = split m[$/], read_file ($karma_file);

  # Set @data to all lines not starting with $user,
  # setting $user_line as the last line starting
  # with $user as a side-effect.  Note that do{}
  # returns the value of the last expression executed,
  # so the 0 is required.
  my $user_line = "";
  my @data = grep { /^$user/ ? do{$user_line = $_;0} : 1 } @lines;

  # We already have $user, and redeclaring it causes a warning.
  # So, instead, we just skip it.
  my (undef, $karma) = split /\s/, $user_line;
  ++$karma;
  push @data, "$user $karma";

  overwrite_file($karma_file, @data);
}

[download]

Update: I like RhetTbull and Zapawork's suggestions better. :-p

bbfu
Seasons don't fear The Reaper.
Nor do the wind, the sun, and the rain.
We can be like they are.

In reply to (bbfu) Re: Storing karma by bbfu
in thread Storing karma by dusk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.