Hello,
I'm just trying to figure out where I stand
in my learning of perl could someone please
point out any sloppy coding, ways I could better
do different parts of my code, and anything
you can tell me that will help me become more
better with my perl coding. =) thanks.
#!/usr/bin/perl -w
use strict;
my (@eachnum, $binary, $good, $decimal);
print("\n\nEnter a binary number:");
chomp($binary=<STDIN>);
if ( $binary =~/\D.*/ ) {
print("Not a binary number!\n");exit;}
if ( $binary =~/\d.*/ ) {
@eachnum = split (//, $binary);
$good = 1;
foreach (@eachnum)
{
next if /0/ || /1/;
print("A binary number contains 1's and 0's!\n");
$good = 0;
last;
}
if ( $good == 1 ) {
convb2d();
}
}
sub convb2d {
$decimal = unpack
( "N", pack("B32", substr("0" x 32 . $binary, -32 )));
print ("Decimal: $decimal\n");
exit;
}
#eNd
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.