A bit late, perhaps, but:

1) I agree that overgenerating and then filtering out unwanted strings is a Bad Idea (too redolent of a bogosort for my liking :).

2) The code below uses the four character classes implicit in the OP.

use strict;
use warnings;

my $password_length = 8 + rand 3;  # Or whatever (here 8-10 chars)
my @classes = ( qw/ upper lower digit punct / );

my @pattern;
for ( 1 .. $password_length ) {
  my @tmp = grep { $_ ne last2( \@pattern ) } @classes;
  push @pattern, $tmp[ rand @tmp ];
}

my %chars;
for my $class ( @classes ) {
   @{ $chars{$class} } = map { chr =~ /[[:$class:]]/g } 0 .. 127;
}

my $password = join '', map ${ $chars{$_} }[ rand @{ $chars{$_} } ], @
+pattern;
print $password;

sub last2 {
  my $to_check = shift;
  return 'ok' if @{ $to_check } < 2;
  return $to_check->[ -1 ] if $to_check->[ -1 ] eq $to_check->[ -2 ];
  return 'ok';
}

[download]

That said, if I were to be issued a password like |V$w`'N#^8, I wouldn't hesitate to write it on a post-it and stick it on my monitor!

In reply to Re: Removing similar characters by Not_a_Number
in thread Removing similar characters by rspishock

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.