You save an alloc and free that way

Yes - I think that's a better approach.
(However, specifying a return type of char * and then returning an SV * is something that doesn't work well for me ;-)
I find the following works as expected (without any need to dynamically allocate/free memory) , and doesn't throw any warnings: 
SV * get_proc_name( int processID )
{
    char szProcessName[MAX_PATH] = {0};

    HANDLE hProcess = OpenProcess
                     ( PROCESS_QUERY_INFORMATION |
                     PROCESS_VM_READ,
                     FALSE, processID );


    if (NULL != hProcess )
    {
        HMODULE hMod;
        DWORD cbNeeded;

        if ( EnumProcessModules( hProcess, &hMod, sizeof(hMod), &cbNee
+ded) )
        {
            GetModuleBaseName( hProcess, hMod, szProcessName, MAX_PATH
+ - 1);
        }
        else {
            szProcessName[0] = '#';
            szProcessName[1] = 0;
        }
    }
    else {
       szProcessName[0] = '*';
       szProcessName[1] = 0;
    }

    CloseHandle( hProcess );
    return newSVpv(szProcessName, 0);
}

[download]
Cheers,
Rob

In reply to Re^5: odd line in windows by syphilis
in thread odd line in windows by xiaoyafeng

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.