Hi Monks!
I need to count the characters from account numbers and if they are less than 14 long I need to include a "X" after the initial letters. My code works but need a second opinion if the code is over kill for such task.
#!/usr/bin/perl
use strict;
use warnings;

my $account_1 = "CALI123456-09";
my $account_2 = "FLOR1234567-01";

my $total_count_1;

   $total_count_1++ while ($account_1 =~ m/./g);

print "Account 1 has $total_count_1 characters\n";

if($total_count_1 < 14) {
  substr($account_1, 4, 0) = 'X';
  print "\n^$account_1^\n";    

}

print "\n*$account_1*\n";
print "*$account_2*\n";

[download]
Thanks for looking!

In reply to Counting to add space to a string by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.