If I understand what your attempting in main.cgi this snippet:

    # Load the keywords used
    my ($terms, @terms);
    if ($s->{terms}) {
        @terms = @{$s->{terms}};
        for (@terms) { $terms .= "$_ " }
        chomp($terms); # for some reason chomp wasn't working here
    }

[download]

might be rewritten:

    # Load the keywords used
    my $terms;
    if ($s->{terms}) {
        $terms = join ' ', @{$s->{terms}};
    }

[download]

but more important is what the code should do if if $s->{terms}is false? Currently strict should throw an error when $terms is used later.


HTH,
Charles K. Clarkson

In reply to Re: Code Review Needed! by CharlesClarkson
in thread Code Review Needed! by redsquirrel

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.