I'll fill out some of the bits jepri left out

As it stands the code has a classic cgi security hole. It trusts user input for file system locations (e.g. ?image=/etc/passwd). Here is a safer rewrite:

#!/usr/local/bin/perl -wT

use strict;
use CGI qw/:all/;

my %images = (
    'tophat'=> {
        'path'=>"/usr/somewhere/way/out/of/reach/Top Hat.jpeg",
        'mime'=>"image/jpeg"},
    'racecar'=> {
        'path'=>"/usr/somewhere/way/out/of/reach/Bugatti.png",
        'mime'=>"image/png"},
    #etc...
);

my $query = CGI::new();
my $file = $query->param("image");

$|=1;
if (defined $images{$file}) {
    print $query->header({-type=>$images{$file}{'mime'}});}
    open ( IMAGE, $images{$file}{'path'} );
    print while ( <IMAGE> );
    close(IMAGE);
}
else {
    print $query->header({-type=>'text/html',
                          -status=>"404 File Not Found"});
}

exit ;

[download]

This is a forgiving approach to bad input, more BOFHish to log and play games.

After Compline,
Zaxo

In reply to Re: Re: Not Strictly A perl question. by Zaxo
in thread Not Strictly A perl question. by kb2yht

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.