Want to avoid using globals at all costs. Instead of passing variables from sub to sub decided to store variables needed for use throughout the program. Just wondering how bad the code is below. Perhaps it's ok but I'm not sure.

I create a basic object then later in the program add more variables to store then access later with getter and setter methods.

Opinions and better practices or ways would be much appreciated. 


# Create Object
my $obj = main->new( '1', 'STORAGE' );

my $string = 'Bad Code?';

# Store string in object
$obj->setter( 'string', $string );

# Later on get string stored in object
my $stored_string = $obj->getter('string');



sub new {
    my $class = shift;
    my $self  = {
        _id  => shift,
        _value=> shift,
    };
    bless $self, $class;
    return $self;
}


sub setter {
    my ( $self, $set_name, $data ) = @_;
    $self->{"_$set_name"} = $data if defined($data);
    return $self->{"_$set_name"};
}


sub getter {
    my ( $self, $get_name ) = @_;
    return $self->{"_$get_name"};
}

[download]

In reply to Avoiding Globals with OO Perl by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.