See update at EOM.

Hi monks,

I just lately started to OOPify the module I've been working on when I decided I'd go the full hog and Mooseify it.

Before, I was using something like this as a shorthand in the parser to make a node of some type:

sub new_node {
    my ($kind, @args) = @_;
    do {
        no strict 'refs';
        my $class = "Erlang::Parser::Node::$kind";
        &{"${class}::new"}($class, @args)
    }
}

[download]

I'm not sure if this is ideal (if not, please do tell!), but it's even less ideal now as I'm getting this with Moose:

Undefined subroutine &Erlang::Parser::Node::Atom::new called at lib/Erlang/Parser/Parser.yp line 33, <DATA> line 1.

If I call new as an actual OO call on the module, it works fine:

my $a = Erlang::Parser::Node::Atom->new(atom => 'xyz'); # sure thing

I'm guessing this is because I don't actually define a new in my own classes (and leave that to Moose), so Erlang::Parser::Node::Whatever::new really doesn't exist!

There is probably some Moose magic I'm missing that I could use to get around this, but I'm still looking! Any wisdom would be very appreciated.

Anneli

Update: ooo... kay. Apparently I missed the most obvious solution of all:

sub new_node {
    my ($kind, %args) = @_;
    "Erlang::Parser::Node::$kind"->new(%args);
}

[download]

I have much to learn.

In reply to Making a new object of an undecided class with Moose by anneli

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.