Checking 20000 files in 3 minutes means you do more than 100 stat checks per second (actually you do double that number because you stat twice for each file) many even on a server link. I think that is pretty fast.

What kind of performance were you expecting?

Update:

I ran a little test myself.

use Modern::Perl; use Time::HiRes qw/time/; open my $LIST, '<', 'M:/YP/list.txt' or die $!; my @stats; my $start = time; while (<$LIST>) { chomp; push @stats, stat "M:/YP/$_"; } my $end = time; say 'stat checks took ', $end - $start, ' seconds.'; say 'That is ', 540 / ($end - $start), ' checks per second.';
I am checking 540 existing files myself over my local network (the "M" drive is on a NAS) and got about 54 stat checks per second. So your performance is actually quite good!

CountZero

A program should be light and agile, its subroutines connected like a string of pearls. The spirit and intent of the program should be retained throughout. There should be neither too little or too much, neither needless loops nor useless variables, neither lack of structure nor overwhelming rigidity." - The Tao of Programming, 4.1 - Geoffrey James


In reply to Re: sizeDateValidator.pl is horribly slow by CountZero
in thread sizeDateValidator.pl is horribly slow by msensay

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.