As far as i can see, yes you are greedy-matching.

Before i start: You don't seem to use strict; and use warnings;, neither the 3-argument version of open, nor checking if open actually worked. Filehandles should also be written as scalars ("$hello") - which you would have noticed when using strict.

I'm a bit oldstyle, i would do it like this:

my @sourceDBHostsFromTnsEntry;
my @sourceDBPortsFromTnsEntry;
open(my $SOURCETNS, "<", "/home/$User/Work/PROJ/$sourceTnsFileName") o
+r die($!);
while((my $record = <$SOURCETNS>)) {
    chomp ($record);
    my @parts = split /\ /, $record;
    foreach my $part (@parts) {
        if($part =~ /HOST=(.*)/o) {
            push @sourceDBHostsFromTnsEntry, $1;
        }
        if($part =~ /PORT=(.*)/o) {
            push @sourceDBPortsFromTnsEntry, $1;
        }
    }
}
close($SOURCETNS);

[download]

If i wrote the program, i also would have decided to use shorter variable names (e.g. names that could be keyed in by remembering them instead of having to do copy&paste ;-)

I didn't test this specific code and there are probably "nicer" ways to do it but it should get the job done (although there may be the odd typo).

Explanation: In the first step, i read in a line and chop it up on the "space" delimeter into @parts. Then, foreach $part in @parts i match against the two tags "HOST=" and "PORT=". If it matches, i put the remainder into their respective arrays.

Don't use '#ff0000':
use Acme::AutoColor; my $redcolor = RED();
All colors subject to change without notice.

In reply to Re: Am I doing Greedy Matching? by cavac
in thread Am I doing Greedy Matching? by vishi

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.