I have posted it (well, an earlier hackier version) to p5p. I'm looking more for things like: mayberelocate() is an awful function name. that's not how you use SvREFCNT_dec(). you should put your function above S_incpush_if_exists(). needs more comments.

I'd like to improve my chances of my patch being accepted before submitting it via perlbug. It might get overlooked or just passed over for being too crude on p5p, and well, the more looking over it gets the better.

In reply to Re^2: Rate my patch: fix -Dusesitecustomize + -Duserelocatableinc by zengargoyle
in thread Rate my patch: fix -Dusesitecustomize + -Duserelocatableinc by zengargoyle

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.