You can't use foreach like this - you need to use while to make your code work. See the code below for a demo:

$data = <<'DATA';
foo 1.1.1.1 foo
bar 22.22.22.22 bar
baz 333.333.333.333 baz
DATA

# this is *wrong*
foreach($data=~ /(\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})/g){
    push @ips, $1;
}

print "Foreach fails and gives:\n";
print "$_\n" for @ips;

@ips = ();

# this is right
while($data=~ /(\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})/g){
    push @ips, $1;
}

print "While works and gives:\n";
print "$_\n" for @ips;
[download]

For an explanation of why the for loop generates three copies of the last IP address you need to consider what has happened. A /g type regex will return an array of matches. So as it is called in array context it returns an array (this actually contains the three addresses) however $1 now contains the last address matched as we had to match all occurences to generate the array. We then iterate over this array and push $1 (the last IP address) into our array three times. To fix this we either use while or push $_ (not $1) into our IP array like this:

$data = <<'DATA';
foo 1.1.1.1 foo
bar 22.22.22.22 bar
baz 333.333.333.333 baz
DATA

foreach($data=~ /(\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})/g){
    push @ips, $_;
}

print "Foreach now gives:\n";
print "$_\n" for @ips;
[download]

Oh you can slurp up the file into a variable $data like this:

open FILE, "<path/to/file" or die "Oops, Perl says: $!";
{
    local $/;
    $data = <FILE>;
}
close FILE;
[download]

cheers

tachyon

s&&rsenoyhcatreve&&&s&n\w+t&"$'$`$\"$\&"&ee&&y&srve&&d&&print

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.