comment on

A couple of observations:

The arguments of srand are not really that random, and quite easy to predict. The documentation for srand suggests using
```
srand( (time() ^ ($$ + ($$ << 15)) );
[download]
```
or simply not using srand, since the default seed now is something better than time().
You are not using all the possible characters for the salt. According to the man page for crypt (in Solaris, at least) the salt is chosen from the set (a-zA-Z0-9./). So you would need to use
```
$random=join("", 'a'..'z','A'..'Z','0'..'9','.','/');
[download]
```
or better yet, replace the for loop with:
```
@r=('a'..'z','A'..'Z','0'..'9','.','/');
$salt=$r[rand(@r)].$r[rand(@r)];
[download]
```

In reply to RE: crypted form by ZZamboni
in thread crypted form by perlvert

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		`&`
	<		`<`
	>		`>`
	[		`[`
	]		`]`

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.