Thanks for your reply. this version of code looks better, but now, I suspect i am on the right way. In order to avoid exposing variables in global, I have to pass 5 paras to cell_work function. and as a module, $callback_data does confuse end user.

to my primitive intention, I just want to separate code into subs and modules for managing. But it now seems to raise complexity of code. do I have to come back to below tedious code? 


# main, use below to substitute cell_walk and callback routine

for ( my $row = 1 ; $row <= $LastRow ; $row++ ) {
    for ( my $col = 1 ; $col <= $LastCol ; $col++ ) {
        next if !defined $Sheet->Cells( $row, $col )->{Value};
        if ( $Sheet->Cells( $row, $col )->{Value} =~ /^~~~/ ) {
            my @a =
              split( /__/, substr( $Sheet->Cells( $row, $col )->{Value
+}, 3 ) );  #grab useful string
              if( scalar @a == 3){
            $Sheet->Cells( $row, $col )->{Value} =
              $hl->get_single_LP( 'ADAS_VAL_RAW', @a );
              }
              if( scalar @a == 4){
            $Sheet->Cells( $row, $col )->{Value} =
              $hl->accu_LP( 'ADAS_VAL_NORM', @a );
              }
        }
    }
}

[download]


I am trying to improve my English skills, if you see a mistake please feel free to reply or /msg me a correction

In reply to Re^2: how organize code in callback mode by xiaoyafeng
in thread how organize code in callback mode by xiaoyafeng

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.