After a closer look, I notice you have ($newbase = $base) on both conditions of your tertiary. My first thought was instead, my $newbase = $base;.

But, you only need $newbase if $base matches the pattern. Further, you stop using $base; you may as well make changes to it rather than $newbase.

So, perhaps this: 

...
for ( @found ) {
   my ($base,$dir)     =  (basename($_),dirname($_));
   next unless $base   =~ /$pat/;
   defined $opts{n}    ?  $base =~ s/$pat/$rep/ 
                       :  $base =~ s/$pat/$rep/g;     
   my $newname         =  File::Spec->catfile($dir,$base); 

   if (-e $newname) {
      warn("can't rename $_ to $newname: $newname already exists\n");
   } else {
      rename($_,$newname) or warn "can't rename $_ to $newname:$!\n";
   }
}

[download]

In reply to Re: Recursive renaming script by hbm
in thread Recursive renaming script by amr noman

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.