OP's code:

open(PID, "> $CONF{upd_lockfile}") ; flock(PID, 2); seek(PID, 0, 2); for my $a (@pids) { print(PID "$a\n") if ($a != $$); } flock(PID, 8);

Problem #1: You don't prevent anyone from modifying the file between the time you read the PIDs and the time you write them.

Problem #2: You release the lock before writing anything to the file. Closing the file would flush its buffers, but you didn't do that. In fact, if you closed the file, you wouldn't even have to unlock it since it's already unlocked.

use Fcntl qw( LOCK_EX ); sub remove_pid { open(my $PID, '+>>', $CONF{upd_lockfile}") or die $!; flock($PID, LOCK_EX) or die $!; seek($PID, 0, SEEK_SET) or die $!; chomp( my @pids = <$PID> ); @pids = grep $_ != $$, @pids; seek($PID, 0, SEEK_SET) or die $!; print($PID "$_\n") for @pids; truncate($PID, tell($PID)) or die $!; kill(CONT => $parend_pid) or die $! if !@pids; close($PID) or die $!; }

But why go to all this trouble for a solution that's inherently fragile? (e.g. Consider what happens if a child gets killed.) Why not have the parent use wait or waitpid instead of suspending itself.


In reply to Re: File lockingProblem by ikegami
in thread File lockingProblem by ric.techow

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.