premal:

You're trying to write the results to the same file you're reading from. Instead, read from one file and write your results to a new file, like so:

my $file1 = "C:\\temp\\file1.txt";
my $file2 = "C:\\temp\\file2.bat";
my $file3 = "C:\\temp\\file3.txt";

open (FILE1,"$file1");
open (FILE2,"$file2");
open (FILE3,">$file3");

my @file1 = <FILE1>;
my @file2 = <FILE2>;

close (FILE1);
close (FILE2);

chomp @file1;

foreach (@file2)
{
    foreach my $search_string (@file1)
    {
        s/$search_string/"******"/g;
    }
    print FILE3;
}
close (FILE3);

[download]

That should solve immediate problem. Note: I haven't tested or run the updated version.

Update: Tweaked per jethro's comments. (I really ought to not code until I finish my coffee... ;^D)

Update 2: To avoid further embarrassment, I tested it and updated again. It passes my tests now.

...roboticus

When your only tool is a hammer, all problems look like your thumb.

In reply to Re: Read strings from a file, search and replace same string in another file. by roboticus
in thread Read strings from a file, search and replace same string in another file. by premal

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.