This is an abuse of the ternary operator.

Normally in this situation, you want to choose between 3 choices, not two!

Use the ternary operator to set a variable dependent upon a true/ false condition.
A common use would be like this:
($today eq 'Monday') ? $firstDay =1 : $firstDay =0;

That would be preferred over:
$firstDay=0;
$firstDay=1 if ($today eq 'Monday');

Use if and if/elsif/else conditions for more complicated things.

#!/usr/bin/perl -w
use strict;

decide ('add');
decide ('edit');
decide ('bad input nothing');

print "\n";

decide2 ('add');
decide2 ('edit');
decide2 ('bad input nothing');


sub decide
{
   my $input = shift;
   
   print "invalid input\n" if ($input ne "add" and $input ne "edit");
   print "doing an add\n"  if $input eq "add";
   print "doing an edit\n" if $input eq "edit";
}

sub decide2
{
   my $input = shift;
   if ($input eq 'add')
   {
      print "the add code goes here\n";
   }
   elsif ($input eq 'edit')
   {
      print "the edit code goes here\n";
   }
   else
   {
      print "the invalid input code goes here\n";
   }
}

__END__
doing an add
doing an edit
invalid input

the add code goes here
the edit code goes here
the invalid input code goes here

[download]

In reply to Re: true/false condition - what am I doing wrong? by Marshall
in thread true/false condition - what am I doing wrong? by ultranerds

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.