I assume your input file is much biggger in reality otherwise I can't imagine this script taking a lot of time. In that case sorting the whole %query hash to only get the 5 highest might be slow

Instead you could use this:

my @result=([0,''],[0,''],[0,''],[0,''],[0,'']); foreach (keys %query) { my $sw; my $n= [$query{$_},$_]; if ($n->[0]>$result[4]) { if ($n->[0]>$result[3]) { if ($n->[0]>$result[2]) { if ($n->[0]>$result[1]) { if ($n->[0]>$result[0]) { $sw=$result[0]; $result[0]=$n; $n=$sw; } $sw=$result[1]; $result[1]=$n; $n=$sw; } $sw=$result[2]; $result[2]=$n; $n=$sw; } $sw=$result[3]; $result[3]=$n; $n=$sw; } $sw=$result[4]; $result[4]=$n; $n=$sw; } } print join("\n",map{$_->[1]},@result);

The speedup of this somewhat ugly contraption lies in the expectation that the first 'if' will be true very very seldom for a big hash


In reply to Re: Speed up my code by jethro
in thread Speed up my code by arivu198314

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.