i don't get the output though...is it a Data::Dump problem?

Hm. Dunno. Are you redirecting the output to a file via the command line? If so, then you may have missed that by default, pp sends its output to STDERR not STDOUT.

If you want it redirected to the same file as the other output, then you should use print pp \%stats;

But if that is not the problem, then you can substitute this for the pp \%stats;

print "$_ => $stats{ $_ }" for sort keys %stats;

Also, you should be using dnacmp() not dnacmp2 with the counting code I posted.

However, that means you are processing each string twice, once to count and once for printing, and that's just doubling your runtime.

Try this instead:

#!/opt/local/bin/perl use Inline C => Config => BUILD_NOISY => 1; use Inline C => <<'END_C', NAME => 'dnacmp', CLEAN_AFTER_BUILD => 0; void dnacmp( char *a, char *b ) { int n = 0; Inline_Stack_Vars; Inline_Stack_Reset; while( *a && *b ) { if( *a != *b ) { Inline_Stack_Push( sv_2mortal( newSVpvf( "%d:%c:%c", n, *a +, *b ) ) ); } a++; b++; n++; } Inline_Stack_Done; return; } SV *dnacmp2( char *a, char *b ) { SV *res = newSVpv( "", 0 ); int n = 0; while( *a && *b ) { if( *a != *b ) sv_catpvf( res, "%d>%c:%c ", n, *a, *b ); ++a, ++b, ++n; } return res; } END_C use Bio::Seq; use Bio::DB::Sam; use Data::Dump qw[ pp ]; my $bamfile = Bio::DB::Sam->new( -bam => "eg1.bam" ); my @allReads = $bamfile->features( -type => 'match' ); my %stats; for my $read (@allReads) { my ( $ref, $matches, $query ) = $read->padded_alignment; my $res = dnacmp2( $ref, $query ); ++$stats{ $1 } while $res =~ m[:(.:.)]g; print $read->qname, "\n", $res, "\n"; } print pp \%stats;

With the rise and rise of 'Social' network sites: 'Computers are making people easier to use everyday'
Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.
"Science is about questioning the status quo. Questioning authority".
In the absence of evidence, opinion is indistinguishable from prejudice.

The start of some sanity?


In reply to Re^11: mismatching characters in dna sequence by BrowserUk
in thread mismatching characters in dna sequence by prbndr

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.