In my experience, monkey patching usually is not worth its trouble. The problem you describe above I would solve by subclassing + duck typing: in Example::ErrorList, provide a method that returns list item class name, and instantiate objects of that name. This way you can subclass both Example::ErrorList and Example::Error in a "clean" way.

Like this:

package Example::ErrorList;

sub list_item_class { 'Example::Error' }

sub new {
    my ($class) = @_;

    my $item_class = $class->list_item_class;

    my $self = bless {}, $class;

    $self->{items} = [ map { $item_class->new($_) } @seed_list_or_some
+thing ];

    return $self;
}

package Example::Error;

sub as_string {
    die "as_string should be implemented by subclass";
}

sub asplode {
    my ($self) = @_;

    die "BANG! ".$self->as_string;
}

package My::AwesomeErrorList;

use base 'Example::ErrorList';

sub list_item_class { 'My::AwesomeError' }

package My::AwesomeError;

use base 'Example::Error';

sub as_string {
    # Actually implement it
}

[download]

You also have a typo: my $self = @_; won't work the way you expect.

Regards,
Alex.

In reply to Re: Safer monkey-patching by dwalin
in thread Safer monkey-patching by tobyink

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.