Bad koolgirl. I gave you nice clean code and you nastised it. Here are a few guidelines to help make it nice again:

  1. define variables where they are first required
  2. use the three argument version of open
  3. use lexical file handles (ones declared with my)
  4. avoid nesting if
  5. don't slurp files and such (for loops implicitly slurp)
  6. show the name for failed opens along with the OS's error message
  7. don't comment block ends. If you avoid nesting, keep blocks short and indent nicely there is no need and it removes clutter

and the niceised code:

use strict;
use warnings;

my $dir = 'F:\project_files';
my $fInName = 'carson_county_abstract.txt';
my $fOutName = 'cars_abstract.txt';
my %docs;

opendir my $dirScan, $dir or die "Failed to open $dir: $!\n";

while (defined(my $entry = readdir $dirScan)) {
    next if $entry !~ /docs(.*)/;

    my $currParcel = $1;
    my $filePath = "$dir\\$entry";

    open my $inFile, '<', $filePath or die "Can't open $filePath: $!\n
+";
    while (defined (my $line = <$inFile>)) {
        chomp $line;
        $docs{$line} = $currParcel;
    }
    close $inFile;
}

open my $fIn, '<', $fInName or die "Failed to open $fInName: $!";
open my $fOut, '<', $fOutName or die "Failed to create $fOutName: $!";
while (defined (my $line = <$fIn>)) {
    next if $line !~ /Document #: ([0-9]*)(.*)/;
    print $docs{$1} . "\n";
    print $fOut "parcel# $docs{$1} doc num $1 $2\n";
}
close $fOut or die "Error closing $fOut: $!\n";

[download]

To fix your duplication problem you might want to use another hash to check for duplicate document/parcel pairs.

Ok, and if you don't understand stuff find a friendly web site dedicated to the area and ask for clarification ;).

True laziness is hard work

In reply to Re^2: Matching and combining two text files by GrandFather
in thread Matching and combining two text files by koolgirl

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.