A more "Perl-ish" way of doing the same thing... 

use strict;
use warnings;
use Term::ANSIColor;
use autodie;

#Program to find motif site in a given protein sequence using files

my $motif = "AGGGGG";
open( my $read, "<dna.txt" );
my @e = <$read>;
$_ = join( " ", @e );
s/\s+//g;
my @c;
push @c, pos( ) - length( $motif ) + 1 while /$motif/g;
s/$motif/color( 'bold green' ) . $motif . color( 'black' )/eg;
print $_, "\n";
print "Number of sites the motif (AGGGGG) is present: ", scalar @c, "\
+n";
print "And the positions in the string are: ", join( ',', @c ), "\n\n"
+;

[download]
The eliminates counting characters one at a time, as in the $i loop in the original, in favor of using pattern matching on the entire character string. I have found that eliminating loop counters wherever possible greatly reduces the number of bugs in my code.

In reply to Re: motif finding by quester
in thread motif finding by devi

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.