legLess wrote:

(I did a quick search/replace on the file and it nailed 115 instances (in ~700 lines) of $prm{'x'}, replacing them with $q->param('x').)

Are all 115 instances going to be called every time? For a 700 line script, I suspect not. Usually, when I get a script that size, it's a variety of different modes and not all are used on any particular invocation. I'm in tadman's camp on this one. Using the CGI object is cleaner because you'll probably use it anyway and why pass the data twice?

I am, however, concerned about something that I am seeing:

    my $q   = CGI->new();
...
    if ($q->param('action') eq 'Login') {
        if ($q->param('mid')) {    ############# <---- What's this?
            $q->param('warning') = 'Already logged in, bonehead.';
            show_member($q);
        } else {
            do_login($q);
        }
    }

[download]

What that seems to suggest is that I should take your form, save it to my box, make sure that it's pointing at your server, and insert a hidden field with the name 'mid' and with a value that evaluates as true. If I do that, your script thinks I'm logged in. At least, that's what the code snippet suggests. How does authentication occur here?

Cheers,
Ovid

Vote for paco!

Join the Perlmonks Setiathome Group or just click on the the link and check out our stats.

In reply to (Ovid) Re: CGI OO 'param' vs. hash by Ovid
in thread CGI OO 'param' vs. hash by legLess

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.